{"root":{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"How to fix SQL Injection that was found by SAST Scanner?","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"heading","version":1,"tag":"h3"},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"The core fix is really about shifting from any kind of raw string concatenation to using parameterized queries or prepared statements. Once you do that, you basically neutralize the risk because the database won't interpret the input as executable SQL. Just follow that approach wherever the SAST tool found vulnerabilities","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"A java code example will be like below:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"So, first, here's the vulnerable version in Java:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"String userId = request.getParameter(\"userId\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"Statement stmt = connection.createStatement();","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"String query = \"SELECT * FROM users WHERE id = '\" + userId + \"'\";","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"ResultSet rs = stmt.executeQuery(query);","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[],"direction":null,"format":"","indent":0,"type":"code","version":1,"textFormat":16},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"And now the fixed version using a prepared statement:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"String userId = request.getParameter(\"userId\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"String query = \"SELECT * FROM users WHERE id = ?\";","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"PreparedStatement pstmt = connection.prepareStatement(query);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"pstmt.setString(1, userId);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"ResultSet rs = pstmt.executeQuery();","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"quote","version":1},{"children":[],"direction":null,"format":"","indent":0,"type":"code","version":1,"textFormat":16},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"In this fixed version, using ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"PreparedStatement","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" with a placeholder ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"?","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" ensures that the user input is safely parameterized and prevents SQL injection.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"\"parameterized\" is essentially that instead of embedding user inputs directly into your SQL queries as raw strings, you use placeholders in the query and then supply the actual values separately.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"So the database knows that these placeholders are just data and not part of the SQL command itself. This way, even if a user tries to inject malicious SQL, it won't be executed as code, just treated as a harmless parameter. It's a safe way to handle user input and a key practice in preventing SQL injection.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"\"\"","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"quote","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"The idea is that when you use parameterization, the database recognizes that the value you're passing in is just a piece of data. It won't try to run it as part of the SQL command itself.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"quote","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"So yes, the same value is going in, but because it's handled as a parameter, the database won't interpret it as executable SQL. That's really the magic of it—it turns potentially dangerous input into harmless data from the database's perspective. \"","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"quote","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"That \"1\" in the ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"pstmt.setString(1, userId)","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" call is indeed the index of the parameter placeholder. In other words, it's telling the database, \"Hey, replace the first ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"?","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" in my query with this ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"userId","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" value.\"","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"If you had multiple placeholders, you'd just increment those indices. So the second ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"?","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" would be ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"2","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":", the third would be ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"3","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":", and so on. It's basically like matching the order of the question marks in your SQL statement to the values you want to insert","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Cross-site scripting, or XSS","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"heading","version":1,"tag":"h3"},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"So besides SQL injection, there are definitely a few other common true positives that SAST tools often flag. One big category is cross-site scripting, or XSS. That's when untrusted data can be injected into a web page and run as a script in someone else's browser.","type":"text","version":1}],"direction":"ltr","format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Let's go with the most common type, which is reflected XSS. This happens when a web application takes user input and immediately includes it in the response without proper escaping. So, for example, in a little snippet of code in something like JavaScript on the server side, you might have something like this","type":"text","version":1}],"direction":"ltr","format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"const userInput = req.query.name;","type":"text","version":1}],"direction":"ltr","format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"res.send(\"

Hello, \" + userInput + \"!

\");","type":"text","version":1}],"direction":"ltr","format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"In this example, if someone puts a script tag in as their name—like ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"—the browser would execute that script.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"The fix would be to properly escape that user input or use a templating engine that automatically escapes it so that any HTML tags get treated as plain text rather than code. But that's the gist of how reflected XSS works!","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"If you're doing it without a framework and just want a simple, in-code way to escape user input, you can basically replace special HTML characters with their safe equivalents.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"For example, you could create a little function that replaces ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"<","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" with ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"<","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":", ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":">","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" with ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":">","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":", and so on. Here's a really simple JavaScript example:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"function escapeHTML(str) {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" return str.replace(/&/g, \"&\")","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" .replace(//g, \">\")","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" .replace(/\"/g, \""\")","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" .replace(/'/g, \"'\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"}","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"const userInput = req.query.name;","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"const safeInput = escapeHTML(userInput);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"res.send(\"

Hello, \" + safeInput + \"!

\");","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"This way, any potentially dangerous characters in the user input are converted into harmless entities that the browser will just display as text rather than running as code. It's a nice and straightforward way to escape user input on your own.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Command Injection","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"heading","version":1,"tag":"h3"},{"children":[{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"Another pretty common SAST finding that's usually a true positive is something like command injection. So command injection is a lot like SQL injection, but instead of injecting SQL, the attacker is injecting operating system commands.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"let's do that in Java. So a similar example in Java might look like this if you were using something like ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"Runtime.getRuntime().exec()","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" to execute a system command directly with user input.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"So the vulnerable version would be something like this:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"import java.io.IOException;","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"public class CommandInjectionExample {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" public static void main(String[] args) throws IOException {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" String userInput = \"some user-provided filename\"; // Imagine this comes from a request or user input","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" Runtime.getRuntime().exec(\"cat \" + userInput);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"}","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"In this example, if the ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"userInput","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" is something malicious, it could run unwanted commands on the system.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"The safer fix would be to avoid passing user input directly into a system command. Instead, you could validate it or use a safer method, like running a predefined command that doesn't concatenate user input directly. But that's the gist of how it looks in Java!","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"To fix command injection in Java, you typically want to avoid directly concatenating user input into your commands. Instead, you can use something like a whitelist of allowed inputs or a safer approach that doesn't let arbitrary input become part of the command line.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Here's a simple example of a more secure function that uses a whitelist approach:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"import java.io.IOException;","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"public class SafeCommandExecution {","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" public static void safeCatCommand(String filename) throws IOException {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Define a whitelist of allowed filenames or a safe directory","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" if (isValidFilename(filename)) {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Use ProcessBuilder for safer command execution","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" ProcessBuilder pb = new ProcessBuilder(\"cat\", filename);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" Process process = pb.start();","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Handle the process output or errors as needed","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // ...","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" } else {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" throw new IllegalArgumentException(\"Invalid filename\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" private static boolean isValidFilename(String filename) {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Implement your validation logic, for example: check against a list of known safe filenames or ensure it doesn't contain dangerous characters","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" return filename.matches(\"[a-zA-Z0-9._-]+\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"}","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"In this example, we use a ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"ProcessBuilder","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" to execute the command safely and a simple validation function to ensure the filename is safe. This way, you're not directly injecting arbitrary user input into the command, and you reduce the risk of command injection.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"second-order injection","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"heading","version":1,"tag":"h3"},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Let's walk through a simple Java example of a second-order injection.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Imagine you have a web app where a user can enter some kind of data—let's say a username that gets stored in a database. Now, when you store it, you don't see any immediate problem because you just save it as text in the database.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"But later, maybe you have another piece of code that reads that username from the database and uses it directly in an HTML page or another SQL query without proper escaping. That's when the malicious input that was stored earlier actually gets executed.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"Here's a simple conceptual example:","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"import java.sql.Connection;","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"import java.sql.ResultSet;","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"import java.sql.Statement;","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"public class SecondOrderInjectionExample {","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" public void storeUserInput(String userInput, Connection conn) throws Exception {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Store the user input in the database (no immediate harm)","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" Statement stmt = conn.createStatement();","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" String query = \"INSERT INTO users (username) VALUES ('\" + userInput + \"')\";","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" stmt.executeUpdate(query);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" public String retrieveAndUseUserInput(int userId, Connection conn) throws Exception {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Retrieve the stored input","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" Statement stmt = conn.createStatement();","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" ResultSet rs = stmt.executeQuery(\"SELECT username FROM users WHERE id = \" + userId);","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" ","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" if (rs.next()) {","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" String storedInput = rs.getString(\"username\");","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" ","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // Now we use this stored input in a new context without escaping","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // For example, directly into HTML or another query","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" // If the stored input contains a malicious payload, it could execute here","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" return \"Hello, \" + storedInput + \"!\";","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" return \"No user found\";","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" }","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"}","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1}],"direction":null,"format":"","indent":0,"type":"code","version":1},{"children":[{"detail":0,"format":0,"mode":"normal","style":"","text":"In this scenario, the username is stored in the database first. Later on, when you retrieve it and use it directly in an HTML context, if that stored input had something malicious in it—like a script tag—it could execute when the page is rendered. So the injection doesn't happen at the time of storage, but when that data is used later on. And that's a classic example of a second-order injection!","type":"text","version":1},{"type":"linebreak","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"The mitigated version will be like","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"import java.sql.*;","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"import org.owasp.encoder.Encode; // OWASP Java Encoder library","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"public class SafeExample {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" public void storeUserInput(String userInput, Connection conn) throws SQLException {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" // 1️⃣ Use a PreparedStatement to safely insert user input","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" String insertQuery = \"INSERT INTO users (username) VALUES (?)\";","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" try (PreparedStatement pstmt = conn.prepareStatement(insertQuery)) {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" pstmt.setString(1, userInput);","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" pstmt.executeUpdate();","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" }","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" }","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" public String retrieveAndDisplayUser(int userId, Connection conn) throws SQLException {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" // 2️⃣ Use PreparedStatement again when retrieving data","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" String selectQuery = \"SELECT username FROM users WHERE id = ?\";","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" String safeHtmlOutput = \"\";","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" try (PreparedStatement pstmt = conn.prepareStatement(selectQuery)) {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" pstmt.setInt(1, userId);","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" ResultSet rs = pstmt.executeQuery();","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" if (rs.next()) {","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" String storedInput = rs.getString(\"username\");","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" // 3️⃣ Encode output before displaying in HTML","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" safeHtmlOutput = \"

Hello, \" + Encode.forHtml(storedInput) + \"!

\";","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" }","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" }","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" return safeHtmlOutput;","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":" }","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":16,"mode":"normal","style":"","text":"}","type":"text","version":1},{"type":"linebreak","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":16,"textStyle":""},{"children":[{"detail":0,"format":1,"mode":"normal","style":"","text":"1. SQL Injection","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"We replaced raw SQL string concatenation with ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"PreparedStatement","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":". This change ensures that user inputs are treated as data—not executable SQL—so malicious SQL can't be injected during inserts or queries.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":1,"textStyle":""},{"children":[{"detail":0,"format":1,"mode":"normal","style":"","text":"2. Second-Order Injection","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"Even though input might look safe when stored, it could later be reused in a dangerous context (like HTML or a SQL query). To mitigate this, we added context-aware encoding right before output. This ensures that any stored payloads are neutralized before they cause harm.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""},{"children":[{"detail":0,"format":1,"mode":"normal","style":"","text":"3. XSS Risk","type":"text","version":1},{"type":"linebreak","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":"We used the OWASP Java Encoder's ","type":"text","version":1},{"detail":0,"format":16,"mode":"normal","style":"","text":"Encode.forHtml()","type":"text","version":1},{"detail":0,"format":0,"mode":"normal","style":"","text":" method before rendering user-supplied input in HTML. This prevents scripts or HTML tags from executing in the browser by converting them into harmless, visible text.","type":"text","version":1}],"direction":null,"format":"","indent":0,"type":"paragraph","version":1,"textFormat":0,"textStyle":""}],"direction":"ltr","format":"","indent":0,"type":"root","version":1,"textFormat":16}}

OculusCyber

Articles

SAST Scanner Findings and Remediations